issue_comments: 914762048

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5776#issuecomment-914762048 https://api.github.com/repos/pydata/xarray/issues/5776 914762048 IC_kwDOAMm_X842hilA 23625371 2021-09-08T01:13:06Z 2021-09-08T01:13:06Z CONTRIBUTOR

We could try and tighten this up in a few ways (I'm not sure how much effort it is worth):

  • only talk about cf_time if the error is in the time dimension (or if one of the types is cftime.datetime)
  • only talk about cf_time if the function which tried to do the combining actually has this argument (e.g. combine_by_coords doesn't have use_cftime, only open_mfdataset does so the current implementation could be confusing), to do this I'd use a try except block further up the stack rather than altering the message in _ensure_same_types

Thoughts @mathause and @TomNicholas ?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   990509161