issue_comments: 914419518

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5692#issuecomment-914419518 https://api.github.com/repos/pydata/xarray/issues/5692 914419518 IC_kwDOAMm_X842gO8- 1217238 2021-09-07T15:44:46Z 2021-09-07T15:45:03Z MEMBER

My suggestion:

Don't include keyword arguments inside the base class: python class Index: def query(self, labels): raise NotImplementedError()

Still include custom keyword arguments on subclass query() methods.

Use # type: ignore inside xarray, when we call query()

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   966983801