home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 910516915

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/5758#issuecomment-910516915 https://api.github.com/repos/pydata/xarray/issues/5758 910516915 IC_kwDOAMm_X842RWKz 10194086 2021-09-01T17:53:04Z 2021-09-01T17:53:04Z MEMBER

I created some workarounds for the problem. But they are only applicable for tests and unfortunately not for the docs...

The issue was that cartopy does not set a `timeout` in `urlopen` so my tests were running forever. Also I did not want to fail my test suite if the download fails. I am now working around this, skipping tests if it cannot be downloaded. (For the docs the no timeout does not seem to be a problem, though.) https://github.com/regionmask/regionmask/blob/e59aaa94f07e1579033ef2436701a1fe99ff3659/regionmask/tests/utils.py#L70 I also cache `~/.local/share/cartopy/` in github actions (note that the cache is only saved if the tests succeed, so it's only a partial solution). https://github.com/regionmask/regionmask/blob/e59aaa94f07e1579033ef2436701a1fe99ff3659/.github/workflows/ci.yaml#L38
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  985376146
Powered by Datasette · Queries took 0.503ms · About: xarray-datasette