home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 908039831

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5731#issuecomment-908039831 https://api.github.com/repos/pydata/xarray/issues/5731 908039831 IC_kwDOAMm_X842H5aX 14808389 2021-08-30T05:24:57Z 2021-08-30T05:24:57Z MEMBER

The already existing test function test_corr does not have a @requires_dask decorator. But it did not fail as it should have. Not sure why.

the reason for this is that dask is imported using importorskip at the top of the module: https://github.com/pydata/xarray/blob/a96154a85e330ce5aec6c34e49997833c1ae0ba2/xarray/tests/test_computation.py#L27 Since most tests already have requires_dask I think it should be fine to just remove the importandskip call.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  976790237
Powered by Datasette · Queries took 0.541ms · About: xarray-datasette