issue_comments: 907281385

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5692#issuecomment-907281385 https://api.github.com/repos/pydata/xarray/issues/5692 907281385 IC_kwDOAMm_X842FAPp 1217238 2021-08-27T15:21:16Z 2021-08-27T15:21:16Z MEMBER

+1 for a class!

On Fri, Aug 27, 2021 at 2:33 AM Benoit Bovy @.***> wrote:

With the latest commits, the return type of Index.query() starts to look ugly:

Tuple[Mapping[str, Any], Optional[IndexWithVars]] where IndexWithVars = Tuple["Index", Optional[IndexVars]]

We need to return:

  • positional indexers in the form {"dim_1": [...], "dim_2": [...]}
  • optionally a new Index object
  • optionally new index variable objects
  • perhaps we should also explicitly return the dimensions to rename (e.g., when only one level of the multi-index remains) instead of inferring it later from the returned index variable(s)?

I think anIndexQueryResults class would be better to hold all this information in a cleaner way. What do you think @shoyer https://github.com/shoyer?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/5692#issuecomment-907066176, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJJFVXV7E2SLUNQMEXVJQTT65LVHANCNFSM5B63RXLQ . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   966983801