issue_comments: 904597086

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/5727#issuecomment-904597086 https://api.github.com/repos/pydata/xarray/issues/5727 904597086 IC_kwDOAMm_X8416w5e 5802846 2021-08-24T12:28:18Z 2021-08-24T12:31:21Z CONTRIBUTOR

Thank you! You are right. I guess based on the docs for Assigning values with indexing I assumed only .loc features item assignment . I vaguely remember there where issues with assigning via integer-based indexing. Well, propably my bad.

Should we add an example how to perform masking this way to the docs? There are many examples about masking using different ways, but not this simple, intuitive way.

Even now, it's not really clear to me why "boolean"-masking should only work with integer-indexing and not label-indexing. Given that the highlighted maybe_cast_to_coords_dtype is the only reason it does not work for label-based indexing.

edit: probably the reason is to support label-based indexing for boolean coords?!

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   976207971