home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 904552118

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/5733#issuecomment-904552118 https://api.github.com/repos/pydata/xarray/issues/5733 904552118 IC_kwDOAMm_X8416l62 4160723 2021-08-24T11:21:22Z 2021-08-24T11:21:22Z MEMBER

Is there any operation in xarray where dimension order matters? If yes, I'm not sure if it's a good idea to allow transposed dimension pass assert_allclose or assert_equal. But even otherwise, I'd find it a bit weird for a "numpy equivalent" function to have:

python xr.testing.assert_allclose(ds1.data, ds2.data) # ok np.testing.assert_allclose(ds1.data.values, ds2.data.values) # fails

What about a check_dim_order option? Also, it would be useful if information about non-matching dimension order was shown more explicitly in the assertion error message.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  977544678
Powered by Datasette · Queries took 0.876ms · About: xarray-datasette