issue_comments: 903176445

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5704#issuecomment-903176445 https://api.github.com/repos/pydata/xarray/issues/5704 903176445 IC_kwDOAMm_X8411WD9 14371165 2021-08-21T21:06:38Z 2021-08-21T21:06:38Z MEMBER

One way of making this less controversial is to also change the default value of chunks from None to {} here https://github.com/pydata/xarray/blob/48a9dbe7d8dc2361bc985dd9fb1193a26135b310/xarray/backends/api.py#L696 Then the default settings will behave the same as before. Although it's still not consistent with xr.open_datasets default parameters which mfdataset is just a thin wrapper around.

It is indeed bad practice to use dicts as default value but not completely uncommon, see for example: https://github.com/pydata/xarray/blob/48a9dbe7d8dc2361bc985dd9fb1193a26135b310/xarray/core/dataset.py#L2111

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   970245117