home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 902468479

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5667#issuecomment-902468479 https://api.github.com/repos/pydata/xarray/issues/5667 902468479 IC_kwDOAMm_X841ypN_ 14371165 2021-08-20T06:38:57Z 2021-08-20T06:38:57Z MEMBER

Is python/mypy#3004 still an issue?

pre-commit suggests it's here: https://github.com/pydata/xarray/pull/5667/files#diff-3c0ce7941684cbac55c00ab890684f86acc1de1908ee2afa915dbcb7c944105aR100 — but I guess there's some reason we can't only accept a MutableMapping in that function?

Yes, it is still an issue. I've cheated though and used type: ignore on a few places, that's why its been passing the checks.

Mappings (in the form of FrozenDict) are used to initialize .attrs in xr.open_dataset for example. So we can't unfortunately accept MutableMappings only.

Does pyright handle properties with setters and getters?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  958878760
Powered by Datasette · Queries took 78.029ms · About: xarray-datasette