home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 899943472

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5682#issuecomment-899943472 https://api.github.com/repos/pydata/xarray/issues/5682 899943472 IC_kwDOAMm_X841pAww 13205162 2021-08-17T02:22:01Z 2021-08-17T02:22:01Z CONTRIBUTOR

Looks great. I'll merge when tests pass.

Thanks @tomchor. I see this is your first PR here. Welcome to xarray!

Thanks!

I think you spoke too soon though haha. One of the tests is failing and I don't really know why! I never touched the test_chunk() function...:

=========================== short test summary info ============================ FAILED xarray/tests/test_sparse.py::test_chunk - TypeError: operand type(s) a... = 1 failed, 13681 passed, 1110 skipped, 225 xfailed, 67 xpassed, 212 warnings in 445.02s (0:07:25) = **PNC:/usr/share/miniconda/envs/xarray-tests/lib/python3.7/site-packages/PseudoNetCDF/pncwarn.py:24:UserWarning: pyproj could not be found, so IO/API coordinates cannot be converted to lat/lon; to fix, install pyproj or basemap (e.g., `pip install pyproj)` Error: Process completed with exit code 1.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  963239311
Powered by Datasette · Queries took 0.53ms · About: xarray-datasette