issue_comments: 897280353

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5690#issuecomment-897280353 https://api.github.com/repos/pydata/xarray/issues/5690 897280353 IC_kwDOAMm_X841e2lh 5635139 2021-08-12T01:41:28Z 2021-08-12T01:41:28Z MEMBER

Unfortunately most test files fail mypy when their tests are changed to -> None — which enables mypy. This is mostly because they reuse variables for different types, though on occasion because our typing isn't quite correct.

I would suggest that new tests use -> None: so mypy checks them, and we build up some tests for our typing through that — any thoughts?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   965939431