issue_comments: 894211410

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/5677#issuecomment-894211410 https://api.github.com/repos/pydata/xarray/issues/5677 894211410 IC_kwDOAMm_X841TJVS 6628425 2021-08-06T12:01:23Z 2021-08-06T12:01:23Z MEMBER

@aidanheerdegen thanks for the report. Are you sure that you are using cftime version 1.5.0? It is surprising to me that the dates are decoded to cftime.datetime objects and not cftime.DatetimeNoLeap objects. I suspect this is where the problem stems from -- currently xarray does not support the universal base class (https://github.com/pydata/xarray/issues/4853).

Eventually the goal is to deprecate the calendar-specific subclasses like cftime.DatetimeNoLeap. For a brief moment -- cftime version 1.4.0 -- the universal class was the default type returned by cftime.num2date, but this proved to be premature, because it broke a significant amount of downstream functionality. More recent versions -- 1.4.1 and later -- have rolled back to returning the subclasses by default. By any chance are you actually using version 1.4.0?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   962467654