issue_comments: 890132667

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/5649#issuecomment-890132667 https://api.github.com/repos/pydata/xarray/issues/5649 890132667 IC_kwDOAMm_X841Dli7 14808389 2021-07-30T20:19:35Z 2021-07-30T20:24:04Z MEMBER

this clearly is a bug in the comparison functions (equivalent or list_equiv). I'm not sure where, though. equivalent calls list_equiv if one of the two arguments is a list (which seems intentional but might be wrong): https://github.com/pydata/xarray/blob/dddac11b01330791ffab4dfc72d226e71821973e/xarray/core/utils.py#L162-L179 and list_equiv seems to assume that both arguments are sized.

Edit: it is wrong, the docstring says "if both objects are lists" so it should be isinstance(first, list) and isinstance(second, list)

would actually not be dropped but resolved to either 5 or [5]?

That might be a bit too special to be included directly in xarray. Note, however, that instead of a name you can also pass a function to combine_attrs so you should be able to customize this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   956259734