issue_comments: 889807390

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5636#issuecomment-889807390 https://api.github.com/repos/pydata/xarray/issues/5636 889807390 IC_kwDOAMm_X841CWIe 4160723 2021-07-30T10:42:10Z 2021-07-30T10:42:10Z MEMBER

This is now ready for review!

The new features (e.g., PandasMultiIndexingAdapter) are not yet integrated with the rest of the code, but it's probably better to do that in a follow-up PR as this one is getting pretty big.

When cleaning up things I noticed that, e.g., for a dataset ds with one dimension coordinate “x”, the corresponding variable ds.variables[‘x’] may wrap a different (pandas) index object than ds.indexes[‘x’] (even though both are equal). I don’t think this has an impact on the cache defined for multi-index coordinates in this PR (when created all these coordinates wrap the same underlying pandas index), but in general this is probably sub-optimal. Maybe we could avoid indexing the indexes twice here too?

There are also some places where the indexes are treated as arrays and that probably need better refactoring than the dirty fixes made here. This is the case for align (see https://github.com/pydata/xarray/issues/5647) and map_blocks (see https://github.com/pydata/xarray/pull/5636#discussion_r679823542).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   953235338