home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 888379766

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5640#issuecomment-888379766 https://api.github.com/repos/pydata/xarray/issues/5640 888379766 IC_kwDOAMm_X84085l2 35968931 2021-07-28T14:57:11Z 2021-07-28T14:57:11Z MEMBER

Thanks for the suggestion @lusewell .

I'm a bit confused as to how exactly this improves performance though - you've moved the location of the import cftime statement to the top of the file, but I was under the impression that python doesn't ever import a module more than once, because after the first time it's a fast hash lookup. So surely in both cases we only look for the existence of cftime once? Perhaps I've misunderstood though?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  954574705
Powered by Datasette · Queries took 2.103ms · About: xarray-datasette