home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 886261206

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5542#issuecomment-886261206 https://api.github.com/repos/pydata/xarray/issues/5542 886261206 IC_kwDOAMm_X84000XW 14371165 2021-07-25T21:38:49Z 2021-07-25T21:38:49Z MEMBER

Edit: actually is this already implemented? https://github.com/pydata/xarray/blob/main/xarray/core/variable.py#L1441-L1444. Does interpolate not hit this code path?

Yes, that's the copy that's slow and there's no real need to create a new copy in the 1D case. My (bad) idea was to just return the original array there instead, but as you noted that might not be fully intuitive.

A ASV for 1D- and ND-interpolation and having it running in the CI would be nice. Though I'm not really interested in implementing that, It would be just another thing to document for me because I use other profilers anyway and as you said getting it setup requires some work that I don't enjoy.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  931016490
Powered by Datasette · Queries took 0.637ms · About: xarray-datasette