issue_comments: 884366726

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5560#issuecomment-884366726 https://api.github.com/repos/pydata/xarray/issues/5560 884366726 IC_kwDOAMm_X840tl2G 2448579 2021-07-21T17:35:36Z 2021-07-21T17:35:36Z MEMBER

so disabling bottleneck would fail the function. Should we just silently use bottleneck, or raise an error?

Ah this is a good test!

python with xr.set_options(use_bottleneck=False): with pytest.raises(...): dataarray.ffill()

IMO it should raise an error so that use_bottleneck is a "global" control on whether xarray uses bottleneck or not. The context manager gives the user some flexibility to opt-in to using bottleneck where they want to.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   935279688