issue_comments: 875091663

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5580#issuecomment-875091663 https://api.github.com/repos/pydata/xarray/issues/5580 875091663 MDEyOklzc3VlQ29tbWVudDg3NTA5MTY2Mw== 14808389 2021-07-06T21:24:02Z 2021-07-06T21:24:02Z MEMBER

I also think we should be able to merge once the points @max-sixty mentioned have been addressed, but if you feel uncomfortable with merging now we can wait until after the next release (which should be soon, given that we have a compatibility issue with pandas=1.3).

The changelog is in /doc/whats-new.rst, and the reprs are documented in /doc/user-guide/data-structures.rst (not sure if that has to be modified), but there might be other files / docstrings.

For tests we usually use pytest.mark.parametrize. This would require a new test function (test_display_max_rows?), where you could check the number of lines of the repr.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   937336962