home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 873459181

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5571#issuecomment-873459181 https://api.github.com/repos/pydata/xarray/issues/5571 873459181 MDEyOklzc3VlQ29tbWVudDg3MzQ1OTE4MQ== 35968931 2021-07-03T19:31:44Z 2021-07-03T19:31:44Z MEMBER

Right I understand the failure now - everywhere where _dask_or_eager_func was dispatching numpy->dask is working fine via NEP-18, but my change made pandas.isnull no longer dispatch to dask.isnull, which then computes (and raises because we want it to be lazy). The solution is to special-case that one use of pandas (and perhaps any other uses of pandas?).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  936313924
Powered by Datasette · Queries took 0.938ms · About: xarray-datasette