issue_comments: 872205035

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/5436#issuecomment-872205035 https://api.github.com/repos/pydata/xarray/issues/5436 872205035 MDEyOklzc3VlQ29tbWVudDg3MjIwNTAzNQ== 14808389 2021-07-01T12:28:40Z 2021-07-01T12:28:54Z MEMBER

because it will not (?) affect the attributes of the variables

that's a misconception: every combine_attrs strategy will affect the attrs on both the variables and the main object. However, "override" was the hard-coded default for variables before the change.

To fix this, I would vote for not using promote_attrs=True in merge (low confidence vote, though, I'm sure there was a reason for that). We could also try to allow specifying separate strategies for main object and variables, but that looks somewhat complicated (and I'm still not sure what syntax we could use for that).

@pydata/xarray, any ideas / opinions?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   911513701