home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 867083353

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5501#issuecomment-867083353 https://api.github.com/repos/pydata/xarray/issues/5501 867083353 MDEyOklzc3VlQ29tbWVudDg2NzA4MzM1Mw== 2443309 2021-06-23T18:58:58Z 2021-06-23T18:58:58Z MEMBER

@grouny - thanks for this PR! And I see that this is your first time contributing to Xarray -- Welcome!

This fix you propose looks great. Apart from the linter complaining about some whitespace, I think this would benefit from a simple test. Would you mind adding a test to xarray/tests/test_backends.py?

Q for @snowman2 - is rioxarray handling complex datatypes in this way?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  925533850
Powered by Datasette · Queries took 2.913ms · About: xarray-datasette