home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 864436695

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5365#issuecomment-864436695 https://api.github.com/repos/pydata/xarray/issues/5365 864436695 MDEyOklzc3VlQ29tbWVudDg2NDQzNjY5NQ== 5635139 2021-06-19T17:02:44Z 2021-06-19T17:02:44Z MEMBER

It's true that Variable doesn't have it. But a Variable can't use that code path since we check getattr(array_large, "coords", False).

Ah, then we can tell mypy this, I think just by switching to isinstance(array_large, Variable)

(and in case it wasn't clear, it's also OK to skip some of these or leave them to another PR. They can be useful checks for things we miss, but we shouldn't be beholden to the linting)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  899015876
Powered by Datasette · Queries took 0.617ms · About: xarray-datasette