issue_comments: 856294922

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5449#issuecomment-856294922 https://api.github.com/repos/pydata/xarray/issues/5449 856294922 MDEyOklzc3VlQ29tbWVudDg1NjI5NDkyMg== 2448579 2021-06-07T22:05:55Z 2021-06-07T22:05:55Z MEMBER

but without much knowledge of how downstream libraries were using these arguments.

IIRC xarray doesn't actually use it. xarray.apply_ufunc is a convenient wrapper for apply_gufunc so we just pass along what the user provides.

@kmuehlbauer added that test so maybe he can provide more context

Perhaps removing one of output_dtypes or meta from the test would be the best solution.

OK good point! There are a few tests for output_dtypes but we don't actually test for providing dtype in meta, so perhaps we should do that. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   913830070