home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 856094670

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/5448#issuecomment-856094670 https://api.github.com/repos/pydata/xarray/issues/5448 856094670 MDEyOklzc3VlQ29tbWVudDg1NjA5NDY3MA== 2448579 2021-06-07T16:43:04Z 2021-06-07T16:43:04Z MEMBER

Thanks for the very well written issue. This is a duplicate of #2037, so I'll close it.

We should skip writing this attribute if there are no NaNs for dimension coordinate variables. It is a common annoyance for users trying to write CF-compliant files.

If you're interested, it's probably a small fix in https://github.com/pydata/xarray/blob/ce01f42134962b63d453657c5cb649ebf152283d/xarray/conventions.py#L707

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  913431220
Powered by Datasette · Queries took 0.664ms · About: xarray-datasette