issue_comments: 854846205

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/5409#issuecomment-854846205 https://api.github.com/repos/pydata/xarray/issues/5409 854846205 MDEyOklzc3VlQ29tbWVudDg1NDg0NjIwNQ== 35968931 2021-06-04T16:16:30Z 2021-06-04T21:16:19Z MEMBER

This is kind of a general question whenever we add new features: if I add to the API such that I can access my new computation newfunc via any of da.newfunc(), ds.newfunc() or xr.newfunc(), then should the tests live in test_dataarray.py, test_dataset.py, test_computation.py, all three of them, or make a new file test_newfunc.py? I agree we should move towards the latter, and try to just make test_dataarray.py & test_dataset.py test the core functionality of those objects, and not their extensive method APIs.

 
{
    "total_count": 3,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   907715257