issue_comments: 854745944

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/5436#issuecomment-854745944 https://api.github.com/repos/pydata/xarray/issues/5436 854745944 MDEyOklzc3VlQ29tbWVudDg1NDc0NTk0NA== 14808389 2021-06-04T14:01:50Z 2021-06-04T14:05:55Z MEMBER

yes, I think so: it is strange to merge the data of a variable but not the attributes (or rather, that the merge strategy of variables is hard-coded to "override").

The only thing I would think of as a bug is that the converted datasets would copy the DataArray's attributes to ds.attrs in addition to keeping it on the variable (not sure if I'm missing something, though?). In the example you gave that does not make sense at all: the dataset object does not have units on its own. Edit: you can work around this by keeping the units on the data instead of in the attributes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   911513701