issue_comments: 850577500
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/pull/5365#issuecomment-850577500 | https://api.github.com/repos/pydata/xarray/issues/5365 | 850577500 | MDEyOklzc3VlQ29tbWVudDg1MDU3NzUwMA== | 5635139 | 2021-05-28T17:53:50Z | 2021-05-28T17:53:50Z | MEMBER | This looks really good, very nice code @Illviljan . I admittedly haven't thought exhaustively through whether we're missing anything. But the tests are great. FWIW the numpy API is not simple — the "length 2 or 3" seems to contribute more complication than value. If anyone thinks that we should instead enforce length 3, I would support that; but otherwise defaulting to the numpy API is good. |
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
899015876 |