issue_comments: 849236342

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4896#issuecomment-849236342 https://api.github.com/repos/pydata/xarray/issues/4896 849236342 MDEyOklzc3VlQ29tbWVudDg0OTIzNjM0Mg== 1217238 2021-05-27T01:08:10Z 2021-05-27T01:08:10Z MEMBER

Also, how do we best construct that object without a lot of overhead? We need to get at least the function name, but if we pass that manually it's one more place to update when renaming something (not that we do that very often). Using inspect is possible but might be too complicated:

Rather than introspection, I think we should try to be fully explicit about the function being called. Trying to introspect it from stack-frames is madness :)

So in that case, we would need to pass down the context information from the top level functions in xarray, e.g., everything that takes a combine_attrs argument.

In terms of the overall interface, one other concern I have is about the information we make available to users of this API. I can imagine that they might not only want attributes but also the complete xarray objects on which the function is being called. If that's the case, then they would also need more information from the global context.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   806811808