issue_comments: 847428630
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/pydata/xarray/pull/5352#issuecomment-847428630 | https://api.github.com/repos/pydata/xarray/issues/5352 | 847428630 | MDEyOklzc3VlQ29tbWVudDg0NzQyODYzMA== | 14808389 | 2021-05-24T23:56:12Z | 2021-05-24T23:56:12Z | MEMBER | I see your points. I chose the name as However, as I said I don't think it matters if the name is reused in a different context, as long as that is not incompatible with our use: we only care about arrays. Which is why I would slightly prefer the second alternative (a generic name and a parameter which is interpreted depending on the context). The only issue I have is that it's usually not a good idea to extend the API unless there's a specific need so I'm somewhat reluctant to add that parameter. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
896002237 |