home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 846113331

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5345#issuecomment-846113331 https://api.github.com/repos/pydata/xarray/issues/5345 846113331 MDEyOklzc3VlQ29tbWVudDg0NjExMzMzMQ== 5635139 2021-05-21T17:14:34Z 2021-05-21T17:14:34Z MEMBER

Yes, pytest can be a bit confusing at first, but it's a really nice framework — da comes from https://github.com/pydata/xarray/blob/v0.18.2/xarray/tests/test_dataarray.py#L6458, which is parametrized with both a numpy-backed and a dask-backed array, so it creates two tests.

I agree this seems like it should be fine, and maybe I'm being a bit too cautious. @keewis could you give this a check given my track-record is blotchy now, and we can merge if you agree?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  895713502
Powered by Datasette · Queries took 0.565ms · About: xarray-datasette