home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 846078946

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5345#issuecomment-846078946 https://api.github.com/repos/pydata/xarray/issues/5345 846078946 MDEyOklzc3VlQ29tbWVudDg0NjA3ODk0Ng== 14371165 2021-05-21T16:21:35Z 2021-05-21T16:21:35Z MEMBER

It's probably worth double-checking that the more complex Variable __getitem__ methods are also tested on Dask arrays. We could you an approach like #5350 if we're not confident.

I don't understand how this works, @max-sixty. You're adding the variable da to the method but where does da then later come from? It doesn't seem to be defined in this file?

The numpy implementation seems very similar to the npcompat version: https://github.com/numpy/numpy/blob/fb215c76967739268de71aa4bda55dd1b062bc2e/numpy/core/numeric.py#L1405

Maybe the npcompat code was copy/pasted just to avoid waiting on numpy releases?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  895713502
Powered by Datasette · Queries took 0.995ms · About: xarray-datasette