issue_comments: 845842353

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5351#issuecomment-845842353 https://api.github.com/repos/pydata/xarray/issues/5351 845842353 MDEyOklzc3VlQ29tbWVudDg0NTg0MjM1Mw== 226037 2021-05-21T10:09:43Z 2021-05-21T10:10:27Z MEMBER

@shoyer I have two suggestions:

  1. I would very much prefer to have the exception in the top level module in order to allow: python import xarray as xr try: ds = xr.open_dataset(...) except xr.NoMatchingEngineError: ...

  2. I feel that the error message is very clear, but the name of the exception seems slightly confusing as it appears to imply that no engine can open the dataset when it is only that we couldn't autodetect which engine to use just inspecting at the filename_or_obj. I would prefer something along the lines of EngineAutodetectionError. But I don't feel too strong about it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   895983112