issue_comments: 840732698

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5285#issuecomment-840732698 https://api.github.com/repos/pydata/xarray/issues/5285 840732698 MDEyOklzc3VlQ29tbWVudDg0MDczMjY5OA== 5635139 2021-05-13T18:03:55Z 2021-05-13T18:03:55Z MEMBER

Can we avoid the signature changes, seems like it creates more trouble than it solves.

I can put the positional ax args back for now, but I do think it would be better not to have in the signature, since it makes it look like you have to provide ax. The _plot2d deals with this by modifying the signature to hide it, but _dsplot doesn't. I do think it is unlikely that many users were using ax positionally, especially since this is never done in the examples, but it is certainly possible.

The positional u, v in dataset_plot.scatter were not used so I think that change is ok?

I agree many of these could be cleaned up. They do probably need a deprecation cycle though — i.e. checking for the previous args, warning if they're supplied, and then only later removing them.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   883153591