home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 835907226

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5284#issuecomment-835907226 https://api.github.com/repos/pydata/xarray/issues/5284 835907226 MDEyOklzc3VlQ29tbWVudDgzNTkwNzIyNg== 5635139 2021-05-09T22:15:25Z 2021-05-09T22:15:25Z MEMBER

Hi @AndrewWilliams3142 , thanks for another PR!

This looks good. Could we add a test like https://github.com/pydata/xarray/pull/4559/files#diff-74d2dc289aa601b2de094fb3a3b687fd65963401b51b95cc5e0afcd06cc4cb82R45? And maybe reference this or #4559 as an explanation of what's going on.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  882876804
Powered by Datasette · Queries took 0.448ms · About: xarray-datasette