home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 835562066

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/5278#issuecomment-835562066 https://api.github.com/repos/pydata/xarray/issues/5278 835562066 MDEyOklzc3VlQ29tbWVudDgzNTU2MjA2Ng== 14808389 2021-05-08T23:04:30Z 2021-05-08T23:04:30Z MEMBER

__array_wrap__ doesn't allow specifying any kwargs (as far as I can tell), it has two parameters: obj and context. I'd have to read up on this, but obj seems to be the data (from asarray or __array_prepare__?) and context seems to be None most of the time.

In any case, I think we should try to replace __array_wrap__ with __array_function__ (or __array_module__ / __array_namespace__?) soon.

Also, I agree on being consistent regarding the out parameter.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  879033384
Powered by Datasette · Queries took 0.674ms · About: xarray-datasette