home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 833520119

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5234#issuecomment-833520119 https://api.github.com/repos/pydata/xarray/issues/5234 833520119 MDEyOklzc3VlQ29tbWVudDgzMzUyMDExOQ== 13301940 2021-05-06T13:24:18Z 2021-05-06T13:24:18Z MEMBER

I feel this PR is too big and diverse to accept it as a whole.

For example I like most changes from older style formatting to f-strings, but I disagree strongly the moving the return statements into functions improves readability.

If folks are in favor of the original style (inline variables that are immediately returned) throughout the codebase, I'm happy to revert back to the original style :)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  870619014
Powered by Datasette · Queries took 0.797ms · About: xarray-datasette