home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 831700309

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/5073#issuecomment-831700309 https://api.github.com/repos/pydata/xarray/issues/5073 831700309 MDEyOklzc3VlQ29tbWVudDgzMTcwMDMwOQ== 226037 2021-05-04T05:57:19Z 2021-05-04T05:57:19Z MEMBER

Sorry for being so late to the party! I thought @aurghs did respond to this issue and forgot about it.

What has happened is not that lock (and group for the matter) disappeared altogether, but it has been moved to be a backend specific keyword argument. As far as I can see most internal backends still support it as before: cfgrib, netcdf4, pseudonetcdf, pynio and scipy.

The main difference is that lock was silently ignored by backend that don't support it like zarr and pydap.

The solution is to in fact only advertise the deprecation for those backends in my opinion as the functionality is legit for most of the backends.

Sorry again for seeing this so late.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  840258082
Powered by Datasette · Queries took 480.744ms · About: xarray-datasette