home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 830237579

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5089#issuecomment-830237579 https://api.github.com/repos/pydata/xarray/issues/5089 830237579 MDEyOklzc3VlQ29tbWVudDgzMDIzNzU3OQ== 5635139 2021-04-30T17:12:02Z 2021-04-30T17:12:02Z MEMBER

This is great work and it would be good to get this in for the upcoming release https://github.com/pydata/xarray/issues/5232.

I think there are two paths: 1. Narrow: merge the functionality which works along 1D dimensioned coords 2. Full: Ensure we're at consensus on how we handle >1D coords

I would mildly vote for narrow. While I would also vote to merge it as-is, I think it's not a huge task to move wide onto a new branch.

@ahuang11 what are your thoughts?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  842940980
Powered by Datasette · Queries took 2.082ms · About: xarray-datasette