issue_comments: 828596025

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/5230#issuecomment-828596025 https://api.github.com/repos/pydata/xarray/issues/5230 828596025 MDEyOklzc3VlQ29tbWVudDgyODU5NjAyNQ== 35968931 2021-04-28T16:28:50Z 2021-04-28T16:29:34Z MEMBER

Okay so I found the problem. If you also pass combine='nested' then it should work - that's what you're supposed to do to open your two datasets.

We currently get an unhelpful error because the default argument combine='by_coords' should be incompatible with passing any value for concat_dim (because the function combine_by_coords doesn't accept any concat_dim argument), but right now that possibility is not checked in any way (it used to be, but got lost in a deprecation cycle...)

To fix this I would simply add an input check that raises an error like "passing a value for concat_dim can only be used with combine='nested', not combine='by_coords'"

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   869948050