home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 828231169

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/5223#issuecomment-828231169 https://api.github.com/repos/pydata/xarray/issues/5223 828231169 MDEyOklzc3VlQ29tbWVudDgyODIzMTE2OQ== 4160723 2021-04-28T07:47:44Z 2021-04-28T07:47:44Z MEMBER

For more context, xarray-simlab doesn't set the _FillValue attribute directly. Instead it uses Xarray's zarr backend, which leaves the _FillValue item as-is in the variable attributes when it is not picked up in decode_cf (i.e., when setting mask_and_scale=False):

https://github.com/pydata/xarray/blob/0021cdab91f7466f4be0fb32dae92bf3f8290e19/xarray/backends/zarr.py#L369-L372

https://github.com/pydata/xarray/blob/ab4e94ec4f6933476ee0d21c937d8f0f8d39ed82/xarray/coding/variables.py#L183-L186

So maybe the original issue should be solved there?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  868907284
Powered by Datasette · Queries took 0.659ms · About: xarray-datasette