issue_comments: 822263369
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/pull/5045#issuecomment-822263369 | https://api.github.com/repos/pydata/xarray/issues/5045 | 822263369 | MDEyOklzc3VlQ29tbWVudDgyMjI2MzM2OQ== | 17001470 | 2021-04-19T08:04:49Z | 2021-04-19T08:04:49Z | CONTRIBUTOR | ok I tried to include your suggestions. Concerning @shoyer's point 3: Since I guess there could be a lot of different errors appearing, I created a copy of the data to be changed to check if the setitem fails before doing the actual update. That's of course suboptimal concerning the performance. What do you think, should we include checks for all conceivable errors or keep this test update? |
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
833778859 |