home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 822162676

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4909#issuecomment-822162676 https://api.github.com/repos/pydata/xarray/issues/4909 822162676 MDEyOklzc3VlQ29tbWVudDgyMjE2MjY3Ng== 14371165 2021-04-19T04:47:45Z 2021-04-19T04:47:45Z MEMBER

I took a quick look and left some minor comments. I do wonder whether it's easier to call DataArray.to_dataset().plot.scatter and port the wonderful legend code to dataset_plot.py

My idea was to slowly move all the code to plot.py and then use the same wrapper function as in #4820, this is what I'm already doing in my local version at least.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  807939559
Powered by Datasette · Queries took 0.929ms · About: xarray-datasette