{"database": "github", "table": "issue_comments", "rows": [["https://github.com/pydata/xarray/pull/5045#issuecomment-822107419", "https://api.github.com/repos/pydata/xarray/issues/5045", 822107419, "MDEyOklzc3VlQ29tbWVudDgyMjEwNzQxOQ==", 1217238, "2021-04-19T01:21:22Z", "2021-04-19T01:21:22Z", "MEMBER", "Strong +1 from me on narrowing scope whenever possible. Adding features\nincrementally is much easier than doing things all at once :)\n\nOn Sun, Apr 18, 2021 at 6:15 PM Maximilian Roos ***@***.***>\nwrote:\n\n> ***@***.**** commented on this pull request.\n> ------------------------------\n>\n> In xarray/core/dataset.py\n> <https://github.com/pydata/xarray/pull/5045#discussion_r615490870>:\n>\n> > +            # loop over dataset variables\n> +            for var, da in self.items():\n> +                val = value\n> +                if type(value) == xr.core.dataset.Dataset:\n> +                    val = value[var]\n> +                # only set value if all dimensions are present\n> +                if all([k in da.dims for k in key.keys()]):\n> +                    da[key] = val\n>\n> V good point. Thanks.\n>\n> Either a) raising on missing dimensions or b) \"entirely set to zero\" in\n> this case, would be reasonable imo.\n>\n> To the extent you're less confident that (b) is correct, I'd suggest we\n> move forward with (a) and evaluating whether we should do (b) separately.\n>\n> (though @shoyer <https://github.com/shoyer> if you're up for it, let's\n> discuss the general pace of reviews next week and whether you think this\n> sort of \"narrowing\" of PR scope is a reasonable tactic)\n>\n> \u2014\n> You are receiving this because you were mentioned.\n>\n>\n> Reply to this email directly, view it on GitHub\n> <https://github.com/pydata/xarray/pull/5045#discussion_r615490870>, or\n> unsubscribe\n> <https://github.com/notifications/unsubscribe-auth/AAJJFVQR6Q6VI44EEY2SF43TJN7ZTANCNFSM4ZKTDBUA>\n> .\n>\n", "{\"total_count\": 1, \"+1\": 1, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", null, 833778859]], "columns": ["html_url", "issue_url", "id", "node_id", "user", "created_at", "updated_at", "author_association", "body", "reactions", "performed_via_github_app", "issue"], "primary_keys": ["id"], "primary_key_values": ["822107419"], "units": {}, "query_ms": 0.820439774543047}