home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 811818035

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5065#issuecomment-811818035 https://api.github.com/repos/pydata/xarray/issues/5065 811818035 MDEyOklzc3VlQ29tbWVudDgxMTgxODAzNQ== 35919497 2021-04-01T10:35:29Z 2021-04-01T10:36:01Z COLLABORATOR

Hmm. I would also be happy with explicitly deleting chunks from encoding for now. It's not adding a lot of technical debt.

I see two reasons for keeping it: - We should be able to read and write the data with the same structure on disk. - The user may be interested in this information.

But it seems to me that having two different definitions of chunks (dask one and encoded one), is not very intuitive and it's not easy to define a clear default in writing.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  837243943
Powered by Datasette · Queries took 3.217ms · About: xarray-datasette