issue_comments: 811135190

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/4213#issuecomment-811135190 https://api.github.com/repos/pydata/xarray/issues/4213 811135190 MDEyOklzc3VlQ29tbWVudDgxMTEzNTE5MA== 35968931 2021-03-31T14:59:17Z 2021-03-31T14:59:17Z MEMBER

Hi @pl-marasco, thanks for your comment.

So what you're suggesting is to alter combine_by_coords and combine_nested to be able to optionally handle overlapping data, presumably with an additional keyword argument to specify the rule it uses?

I think that this could be done within the combine functions, but it's not trivial... At the moment if you pass data with big gaps in it to combine_by_coords it can fill it with NaNs, so that's at least sort of the inverse of what you're suggesting.

Internally the combine functions currently work by creating an intermediate representation of the arrangement of tiles, before combining that along 1D repeatedly until done. What I'm wondering is whether any treatment of overlapping values would need to happen before this 1D combining step? If I have 4 tiles which all overlap at a corner, and you want me to take the (max/min/average) value of all 4 in that quadruple overlap region, I could either do this by identifying that region and taking the max (complicated) or by simply updating the max value every time I combine along 1D (simple, but more wasteful). Separately, a treatment based on the order of the input passed (your first/last) would I think need to store extra information about that order, which would be more complicated.

Do these raster problems always use the same sized tiles?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   654150730