home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 810933252

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/5093#issuecomment-810933252 https://api.github.com/repos/pydata/xarray/issues/5093 810933252 MDEyOklzc3VlQ29tbWVudDgxMDkzMzI1Mg== 6628425 2021-03-31T09:47:57Z 2021-03-31T09:47:57Z MEMBER

Many thanks for the clear report. I totally agree we should be able to handle this. It would be great if you could put together a PR with a fix and some added test coverage.

My only suggestion would be to implement your fix at a higher level in the call stack, e.g. by converting the input calendar to lowercase within xarray.coding.times.decode_cf_datetime before using it anywhere else. I think this may be cleaner since we do similar checks to the one in _decode_datetime_with_pandas in other places, e.g. here.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  844712857
Powered by Datasette · Queries took 0.774ms · About: xarray-datasette