issue_comments: 808736180

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4972#issuecomment-808736180 https://api.github.com/repos/pydata/xarray/issues/4972 808736180 MDEyOklzc3VlQ29tbWVudDgwODczNjE4MA== 12229877 2021-03-27T13:51:54Z 2021-03-27T13:51:54Z CONTRIBUTOR

Looking at https://github.com/keewis/xarray/compare/duckarray-tests...duckarray-tests-hypothesis, for high-level feedback:

  • Overall it looks pretty good; though ping me again if/when it's a PR and I'll do line-level feedback on idiom issues
  • A more general test would generate the shapes, and the axes to reduce over - reducing a 1D array over the first dimension is going to miss things
  • You use @st.composite when the .map() method and a lambda would suffice (though the perf gain is small enough that this is mostly a readability issue)
  • I don't see the point of Label, and we advise against mixing "a strategy or a value". We break this rule a few times for backwards-compatibility in our Numpy support, but wouldn't write such an API these days.

And I'm always delighted to see people using Hypothesis to test libraries that I use and love 🥰🤩

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   818059250