issue_comments: 798989229

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4659#issuecomment-798989229 https://api.github.com/repos/pydata/xarray/issues/4659 798989229 MDEyOklzc3VlQ29tbWVudDc5ODk4OTIyOQ== 14808389 2021-03-14T22:10:00Z 2021-03-14T22:10:00Z MEMBER

I don't think there is a lot left to decide: we want to keep the conversion logic in from_dask_dataframe and maybe helper functions, and I think we should mirror the pandas integration as close as possible (which means we need a Dataset.from_dask_dataframe and a DataArray.from_dask_series class method).

The only thing I think is left to figure out is how to best compute the chunk sizes with as few computations of dask (as defined by raise_if_dask_computes) as possible.

cc @dcherian

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   758606082