issue_comments: 793121127

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4979#issuecomment-793121127 https://api.github.com/repos/pydata/xarray/issues/4979 793121127 MDEyOklzc3VlQ29tbWVudDc5MzEyMTEyNw== 1217238 2021-03-08T22:15:34Z 2021-03-08T22:15:34Z MEMBER

One thing that is not in the notes: to which acceptable extent this refactoring may introduce breaking changes? I think that it will be hard to avoid any breaking change. That said, as the index refactoring would rather bring internal data structures to the light I don't expect many things to break (at least, not the things that 90% of Xarray users often rely on). Hardest part will probably be to ensure a smooth transition while updating the API that is too specific to pandas.MultiIndex into something that is more index-agnostic...

My opinion is that breaking changes are OK if done with care. The main thing to keep in mind is that users dealing with change typically will not directly benefit from it.

So any breaking changes need to be intentional, and happen all at once in a major release. We also need to issue warnings when possible.

Depending on the magnitude of these changes, this could be a good reason to declare "xarray 1.0"

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   819062172