issue_comments: 779709464

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4911#issuecomment-779709464 https://api.github.com/repos/pydata/xarray/issues/4911 779709464 MDEyOklzc3VlQ29tbWVudDc3OTcwOTQ2NA== 367900 2021-02-16T09:36:32Z 2021-02-16T09:36:32Z CONTRIBUTOR
  • Changed to use duck_array_ops.where
  • Docstring updated and entry added to breaking changes of whats new (I assumed this was appropriate). Note its a bit more nuanced than @mathause stated: for an integer array, skipna defaults to False and so xarray.core.duck_array_ops._create_nan_agg_method does not call nansum. This means you have to force skipna=True to see the difference:
    • master: xr.DataArray([1]).sum(min_count=1).dtype -> int64
    • this PR: xr.DataArray([1]).sum(min_count=1).dtype -> int64
    • master: xr.DataArray([1]).sum(skipna=True, min_count=1).dtype -> int64
    • this PR: xr.DataArray([1]).sum(skipna=True, min_count=1).dtype -> float64

Hopefully this is clear in the docstring changes, suggestions welcome.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   808558647